Skip to content

feat: honor serverless_logs #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
duncanista merged 2 commits into from
Nov 25, 2024
Merged

feat: honor serverless_logs #475

duncanista merged 2 commits into from
Nov 25, 2024

Conversation

@astuyve
Copy link
Contributor

@astuyve astuyve commented Nov 25, 2024 •
edited
Loading

  1. Looks like we had this at some point and either removed it or it was not completed (my bad ya'll!)
  2. Honors DD_SERVERLESS_LOGS
  3. Sets it as default: true. This is a breaking change from the main agent which defaults to false, but every single integration (cdk construct, serverless plugin, macro) enables it by default with opt-in (so if the customer actively disables it, the env var is still set), so I think this is safe.

fixes #476

@astuyve astuyve requested a review from a team as a code owner November 25, 2024 16:54
@duncanista duncanista merged commit 3b19fe7 into main Nov 25, 2024
12 checks passed
@duncanista duncanista deleted the aj/honor-serverless-logs branch November 25, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@duncanista duncanista duncanista approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Encounter log message duplication with DD_EXTENSION_VERSION next

3 participants

@astuyve @duncanista